Change the logic of NewVersionTest #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handling the new alert when creating a new version of an item that is in moderation * refactoring code to reduce duplicated code
SammyIsConfused
suggested changes
Feb 26, 2019
| itemList = adminPage.results(); | ||
| // Login as SimpleModerator and moderate the new version of this item at the first step. | ||
| logon(FIRST_MODERATOR_USERNAME, BACKTICK_PASSWORD); | ||
| doModeration(FIRST_MODERATOR_USERNAME, BACKTICK_PASSWORD, "moderation step 1", itemFullName2,false); |
There was a problem hiding this comment.
Maybe create a constant for "moderation step 1" string, as it is used more than once. Probably step 2 as well, for consistency.
| @TestInstitution("workflow") | ||
| public class NewVersionTest extends AbstractCleanupTest | ||
| { | ||
| private static final String BACKTICK_PASSWORD = "``````"; |
There was a problem hiding this comment.
Since these are all public static final String, the whitespaces between each line should be removed.
| WizardPageTab wizard = new ContributePage(context).load().openWizard("Move to Live During Moderation"); | ||
| String itemFullName = context.getFullName("item"); | ||
| String itemFullName2 = itemFullName + " 2"; | ||
| wizard.editbox(1, itemFullName); | ||
| wizard.save().submit(); | ||
| saveItem(wizard,1,itemFullName); |
There was a problem hiding this comment.
There should be space between the parameters.
edalex-ian
requested changes
Feb 26, 2019
| logout(); | ||
| } | ||
|
|
||
| private void doModeration(String username, String password, String stepName, String itemFullName, Boolean lastModeration) { | ||
| TaskListPage taskListPage = new TaskListPage(context).load(); |
There was a problem hiding this comment.
username and password are unused. Remove.
| // Login as SimpleModerator and moderate the new version of this item at the first step. | ||
| logon(FIRST_MODERATOR_USERNAME, BACKTICK_PASSWORD); | ||
| doModeration(FIRST_MODERATOR_USERNAME, BACKTICK_PASSWORD, STEP_NAME_ONE, itemFullName2,false); | ||
| // After moderation, check that the item has gone life after the first moderation step |
There was a problem hiding this comment.
typo:
has gone
life
should be
has gone live
| ModerationView tasksTab = modResults.moderate(itemFullName); | ||
| tasksTab.assignToMe(); | ||
| tasksTab.accept(); | ||
| } |
There was a problem hiding this comment.
For this if/else the braces should follow the statement.
Shame we don't have formatting here yet, but we will once we merge this repo in.
PenghaiZhang
force-pushed
the
feature/new_version_alert_test
branch
from
ce8d91b
to
e7d534d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling the new alert when creating a new version of an
item that is in moderation
refactoring code to reduce duplicated code